Parser: Introduce StrayERBClosingTagError#1256
Merged
Merged
Conversation
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
marcoroth
force-pushed
the
parser-stray-erb-closing-error
branch
from
8eb2297 to
0c92ad7
Compare
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
StrayERBClosingTagErrorthat detects%>appearing outside of ERB tags.Inside an open tag, the
%>is always reported as an error. The parser consumes both tokens, adds aLiteralNodeto preserve the source, and continues parsing the tag. Therefore subsequent attributes and the real>closing are not lost anymore:At the document top level, the
%>is reported only in strict mode. In non-strict mode it is silently absorbed as text, matching Erubi's behavior for backwards compatibility, if needed.The error message suggests using
%>HTML entities for cases where a literal%>is intended.